Skip to content

feat: add Undo/Cut/Copy/Paste keycodes - #5591

Open
TinfoilSubmarine wants to merge 2 commits into
LizardByte:masterfrom
TinfoilSubmarine:undo_cut_copy_paste
Open

feat: add Undo/Cut/Copy/Paste keycodes#5591
TinfoilSubmarine wants to merge 2 commits into
LizardByte:masterfrom
TinfoilSubmarine:undo_cut_copy_paste

Conversation

@TinfoilSubmarine

@TinfoilSubmarine TinfoilSubmarine commented Aug 31, 2026

Copy link
Copy Markdown

Description

Continuation of #5397 with libvirtualhid.

Add support for Undo/Cut/Copy/Paste keycodes (keyboard HID spec usage IDs 0x7A-0x7D). In order to do this I added some ad-hoc/bespoke keycodes in libvirtualhid.

Depends on LizardByte/libvirtualhid#120

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@TinfoilSubmarine TinfoilSubmarine changed the title add non-VK Undo/Cut/Copy/Paste keycodes add Undo/Cut/Copy/Paste keycodes Aug 31, 2026
@TinfoilSubmarine TinfoilSubmarine changed the title add Undo/Cut/Copy/Paste keycodes feat: add Undo/Cut/Copy/Paste keycodes Aug 31, 2026
@TinfoilSubmarine TinfoilSubmarine mentioned this pull request Aug 31, 2026
Open
@sonarqubecloud

sonarqubecloud Bot commented Sep 1, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ReenigneArcher
ReenigneArcher requested changes Sep 2, 2026
View reviewed changes

@ReenigneArcher ReenigneArcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you preserve whether the original packet contained the 0x8000 normalized-key prefix before applying this conversion?

SS_KBE_FLAG_NON_NORMALIZED alone does not distinguish these SDL scancodes from F11–F14. Moonlight Android can set that flag when keyboard-layout normalization is unavailable while still sending 0x8000 | VK_*. With the current ordering, 0x807A becomes 0x7A and is then converted from F11 to Undo; F12–F14 similarly become Cut/Copy/Paste.

Please either apply the 0x7A–0x7D aliases only when the original keycode did not contain 0x8000, or remove the ambiguous aliases and accept only the dedicated 0x0100–0x0103 values. A regression test should cover 0x807A–0x807D with SS_KBE_FLAG_NON_NORMALIZED.

When rebasing this PR, please preserve master’s current remapped-key release behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ReenigneArcher ReenigneArcher ReenigneArcher requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TinfoilSubmarine @ReenigneArcher